Add Events view #1592
Merged
Add Events view #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All tests passed |
Last 2 events on the Overview Card
Events viewThe table
Small screen
Filters
No events found
|
Merged
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
All tests passed |
|
Changes in the last force push:
|
|
All tests passed |
sjd78
added a commit
to sjd78/ovirt-web-ui
that referenced
this pull request
Jun 9, 2022
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 ** pending merge - oVirt#1592 ** pending merge
Before, filtering and sorting was tied to VM entities. After this patch the generic filter/sort component can be reused for other entities. Filter component changes: 1. create a new type of filter - a date filter 2. generalize name filter to text based filter - as before only one filter of this type is supported per filter toolbar 3. extract enum based filter as SelectFilter Sort component changes: 1. refactor SortFields from constant to parameter 2. drop unused isNumeric flag - natural sort order is used for all types of input
Changes on the VM Details -> Overview Card: 1. display last 2 events that are associated with the VM 2. provide a "View All" link to a new sub-page: the Events view. Events view features: 1. display events in a table with 3 columns: a) severity b) date (includes time) c) message 2. allow filtering and sorting for all columns via toolbar 3. limit the max number of events that can be fetched to 500 4. do incremental refresh by fetching only new events
|
All tests passed |
|
All tests passed |
sjd78
added a commit
to sjd78/ovirt-web-ui
that referenced
this pull request
Jun 14, 2022
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 - oVirt#1592 ** pending merge
sjd78
added a commit
to sjd78/ovirt-web-ui
that referenced
this pull request
Jun 14, 2022
After merging PRs and pushing their string changes, pull the translations. This picks up translation invalidations (English text has changed), helping to make sure the translations are not wrong. PRs to consider: - oVirt#1533 - oVirt#1537 - oVirt#1539 - oVirt#1540 - oVirt#1543 - oVirt#1549 - oVirt#1564 - oVirt#1584 - oVirt#1585 - oVirt#1592
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Aug 31, 2022
Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Aug 31, 2022
Changes: 1. display all providers in ons table 2. provide attribute-value filter implementation with: a) free text filter b) enum based filter Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Sep 6, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Sep 12, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Sep 20, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Sep 23, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Oct 4, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Oct 10, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Oct 20, 2022
Functional changes: 1. display all providers in one table 2. use only 'Ready' condition to describe the state of the provider Components created: 1. primary filters component for displaying few (1-3) most important filters. The filters are grouped but displayed independently. 2. attribute-value filter implementation for grouping all other filters in a space efficient way 3. default filter types: a) free text filter - substring search based on multiple terms - search terms confirmed by 'Enter' key b) enum based filter - exact match based on checkboxes selected 4. generic table component providing sorting capabilities Reference-Url: oVirt/ovirt-web-ui#1600 Reference-Url: oVirt/ovirt-web-ui#1592 Reference-Url: https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter Signed-off-by: Radoslaw Szwajkowski <[email protected]>
rszwajko
added a commit
to rszwajko/forklift-console-plugin
that referenced
this pull request
Oct 28, 2022
Components created:
1. standard list page component
a) page skeleton following openshift console layout and practice
b) generic component parametrized by the entity type
c) design is view independent and follows the approach used in oVirt
PR 1600 and 1592. Currently only table view implementation is
provided.
2. primary filters component
a) implementation of PatternFly 4 filter group pattern[1] extended to
support all filters implementing FilterTypeProps interface.
b) use case: displaying few (1-3) most important filters.
The filters are grouped but displayed independently.
3. attribute-value filter component
a) implementation of PatternFly 4 attribute-value filter pattern[2]
b) use case: grouping all other filters in a space efficient way
c) supports all filters implementing FilterTypeProps interface.
4. filter components:
a) free text filter
- substring search based on multiple terms
- search terms confirmed by 'Enter' key or by button
b) enum based filter
- exact match based on checkboxes selected
5. table view component
a) parametrized by the entity type
b) row mapper component is entity-specific which allows complex
customizations
c) sorting capabilities (via arrows in the table header)
6. dialog for managing column visibility and order
a) based on openshift console solution [3] and PatternFly 4 demo[4]
b) toggle column visibility (except identity columns)
c) re-order columns using drag and drop
Updated libraries:
1. Downgrade @testing-library/react to ^12.0 since ^13.0 requires
react >= 18.
2. Bump @openshift/dynamic-plugin-sdk* to 1.0.0
[1] https://www.patternfly.org/v4/guidelines/filters/#filter-group
[2] https://www.patternfly.org/v4/guidelines/filters#attribute-value-filter
[3] https://github.com/openshift/console/blob/release-4.12/frontend/public/components/modals/column-management-modal.tsx
[4] https://www.patternfly.org/v4/components/table/react-demos#column-management-with-draggable
Reference-Url: oVirt/ovirt-web-ui#1600
Reference-Url: oVirt/ovirt-web-ui#1592
Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #1585
Changes on the VM Details -> Overview Card:
Events view features:
a) severity
b) date (includes time)
c) message